Re: pgsql: pgindent: preserve blank lines around #else/#endif - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: pgindent: preserve blank lines around #else/#endif
Date
Msg-id 20140213215240.GG32126@momjian.us
Whole thread Raw
In response to Re: pgsql: pgindent: preserve blank lines around #else/#endif  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: pgindent: preserve blank lines around #else/#endif  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-committers
On Thu, Feb 13, 2014 at 03:52:02PM -0500, Tom Lane wrote:
> >> else if (def->defnamespace == NULL)
> >> continue;
> >> +
> >> else if (pg_strcasecmp(def->defnamespace, namspace) != 0)
> >> continue;
> >>
> >> This seems an odd change to be making.
>
> > I just tested pgindent in head against that file in 9.3 and head and
> > didn't see that additional blank line, which is certainly odd.
>
> It doesn't do that for me either.

We have to expand our pgindent testing in the southern hemisphere.  ;-)

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: pgindent: preserve blank lines around #else/#endif
Next
From: Bruce Momjian
Date:
Subject: pgsql: docs: improve CREATE FUNCTION docs about language case and quoti