Re: trailing comment ghost-timing - Mailing list pgsql-hackers

From Martijn van Oosterhout
Subject Re: trailing comment ghost-timing
Date
Msg-id 20131224075301.GB7881@svana.org
Whole thread Raw
In response to Re: trailing comment ghost-timing  (Andreas Karlsson <andreas@proxel.se>)
Responses Re: trailing comment ghost-timing
Re: trailing comment ghost-timing
List pgsql-hackers
On Tue, Dec 24, 2013 at 03:40:58AM +0100, Andreas Karlsson wrote:
> On 12/24/2013 03:17 AM, David Johnston wrote:
> It is not sent to the server as a trailing comment. The following
> file is sent to the server like this.
>
> File:
> /**/;
> /**/
>
> Commands:
> PQexec(..., "/**/;");
> PQexec(..., "/**/");
>
> If this has to be fixed it should be in the client. I think people
> would complain if we broke the API by starting to throw an exception
> on PQexec with a string containing no actual query.

(Untested). Isn't this just a case of psql not printing out a timing if
the server responds with PGRES_EMPTY_QUERY?

Have a nice day,
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> He who writes carelessly confesses thereby at the very outset that he does
> not attach much importance to his own thoughts.  -- Arthur Schopenhauer

pgsql-hackers by date:

Previous
From: Abbas Butt
Date:
Subject: Re: varattno remapping
Next
From: Fabrízio de Royes Mello
Date:
Subject: Re: trailing comment ghost-timing