Re: [PATCH] Use MAP_HUGETLB where supported (v3) - Mailing list pgsql-hackers

From Abhijit Menon-Sen
Subject Re: [PATCH] Use MAP_HUGETLB where supported (v3)
Date
Msg-id 20131118072952.GA17956@toroid.org
Whole thread Raw
In response to Re: [PATCH] Use MAP_HUGETLB where supported (v3)  (Heikki Linnakangas <hlinnakangas@vmware.com>)
Responses Re: [PATCH] Use MAP_HUGETLB where supported (v3)  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
At 2013-11-15 15:17:32 +0200, hlinnakangas@vmware.com wrote:
>
> I spent some time whacking this around, new patch version attached.

Thanks.

> But I'm not wedded to the idea if someone objects; a log message might
> also be reasonable: "LOG: huge TLB pages are not supported on this
> platform, but huge_tlb_pages was 'on'"

Put that way, I have to wonder if the right thing to do is just to have
a "try_huge_pages=on|off" setting, and log a warning if the attempt did
not succeed. It would be easier to document, and I don't think there's
much point in making it an error if the allocation fails.

-- Abhijit

P.S. I'd be happy to do the followup work for this patch (updating
documentation, etc.), but it'll have to wait until I recover from
this !#$&@! stomach bug.



pgsql-hackers by date:

Previous
From: Alexey Klyukin
Date:
Subject: Re: Wildcard usage enhancements in .pgpass
Next
From: wangshuo@highgo.com.cn
Date:
Subject: Parse more than bind and execute when connect to database by jdbc