[PATCH] warning: suggest braces around empty body in an 'else' statement - Mailing list pgsql-hackers

From Andres Freund
Subject [PATCH] warning: suggest braces around empty body in an 'else' statement
Date
Msg-id 20131107230039.GK28314@alap2.anarazel.de
Whole thread Raw
Responses Re: [PATCH] warning: suggest braces around empty body in an 'else' statement
List pgsql-hackers
Hi,

Compiling postgres I currently get the following warning when compiling
without LOCK_DEBUG:
/home/andres/src/postgresql/src/backend/storage/lmgr/lock.c:944:52:
warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
     PROCLOCK_PRINT("LockAcquire: NOWAIT", proclock);

It'd be easy to just disable the warning with -Wno-empty-body, but I actually like
the warning.

It's easy to fix by defining PROCLOCK_PRINT to (void)0 instead of
defining it empty when LOCK_DEBUG is enabled.

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Using indices for UNION.
Next
From: "Joshua D. Drake"
Date:
Subject: Re: Changing pg_dump default file format