Re: relscan_details.h - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: relscan_details.h
Date
Msg-id 20131002135056.GO5235@eldon.alvh.no-ip.org
Whole thread Raw
In response to Re: relscan_details.h  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian escribió:
> On Wed, Oct  2, 2013 at 08:59:42AM -0400, Noah Misch wrote:
> > On Tue, Oct 01, 2013 at 10:12:05PM -0400, Bruce Momjian wrote:
> > > If we had not made massive cleanup changes years ago, our code would not
> > > be as good as it is today.  By avoiding cleanup to reduce the burden on
> > > people who use our code, we are positioning our code on a slow decline
> > > in clarity.
> > > 
> > > What I don't want to do is get into a mode where every code cleanup has
> > > to be verified that it isn't going to excessively burden outside code
> > > users.  Cleanup is hard enough, and adding another check to that process
> > > makes cleanup even less likely.
> > 
> > I don't disagree with that, but I would describe the proposal as a mild
> > dirty-up for the sake of build performance, not a cleanup.
> 
> OK, good enough.  Thanks for the feedback.

Agreed.  I will keep this patch in my local repo; I might present it
again later as part of more invasive surgery.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Merlin Moncure
Date:
Subject: Re: Who is pgFoundery administrator?
Next
From: Kevin Grittner
Date:
Subject: Re: [PATCH] pg_upgrade: support for btrfs copy-on-write clones