Re: relscan_details.h - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: relscan_details.h
Date
Msg-id 20131002131123.GA21547@momjian.us
Whole thread Raw
In response to Re: relscan_details.h  (Noah Misch <noah@leadboat.com>)
Responses Re: relscan_details.h  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Wed, Oct  2, 2013 at 08:59:42AM -0400, Noah Misch wrote:
> On Tue, Oct 01, 2013 at 10:12:05PM -0400, Bruce Momjian wrote:
> > If we had not made massive cleanup changes years ago, our code would not
> > be as good as it is today.  By avoiding cleanup to reduce the burden on
> > people who use our code, we are positioning our code on a slow decline
> > in clarity.
> > 
> > What I don't want to do is get into a mode where every code cleanup has
> > to be verified that it isn't going to excessively burden outside code
> > users.  Cleanup is hard enough, and adding another check to that process
> > makes cleanup even less likely.
> 
> I don't disagree with that, but I would describe the proposal as a mild
> dirty-up for the sake of build performance, not a cleanup.

OK, good enough.  Thanks for the feedback.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +



pgsql-hackers by date:

Previous
From: Sameer Thakur
Date:
Subject: Re: pg_stat_statements: calls under-estimation propagation
Next
From: Bruce Momjian
Date:
Subject: Re: Looking for information on our elephant