C question about bitmasks in datetime.c - Mailing list pgsql-hackers

From Bruce Momjian
Subject C question about bitmasks in datetime.c
Date
Msg-id 20131001151536.GC13385@momjian.us
Whole thread Raw
Responses Re: C question about bitmasks in datetime.c  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
I see a few cases of this code in src/backend/utils/adt/datetime.c:
   else if ((fmask & DTK_DATE_M) != DTK_DATE_M)

Wouldn't this be clearer as:
   else if (fmask & DTK_DATE_M)

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: logical changeset generation v6.1
Next
From: Andres Freund
Date:
Subject: Re: C question about bitmasks in datetime.c