Re: [PATCH] pg_upgrade: Split off pg_fatal() from pg_log() - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [PATCH] pg_upgrade: Split off pg_fatal() from pg_log()
Date
Msg-id 20130926215638.GC7113@momjian.us
Whole thread Raw
In response to [PATCH] pg_upgrade: Split off pg_fatal() from pg_log()  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On Thu, Sep 12, 2013 at 10:50:42PM -0400, Peter Eisentraut wrote:
> The experiences with elog() and ereport() have shown that having one
> function that can return or not depending on some log level parameter
> isn't a good idea when you want to communicate well with the compiler.
> In pg_upgrade, there is a similar case with the pg_log() function.
> Since that isn't a public API, I'm proposing to change it and introduce
> a separate function pg_fatal() for those cases where the calls don't
> return.

Fine with me.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: record identical operator - Review
Next
From: Alexander Korotkov
Date:
Subject: Re: GIN improvements part 1: additional information