Re: GIN improvements part 1: additional information - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: GIN improvements part 1: additional information
Date
Msg-id CAPpHfdtjtZCnmm334+eLB1844k8FWbwtSjvZbkfqa1HgzjWCEQ@mail.gmail.com
Whole thread Raw
In response to Re: GIN improvements part 1: additional information  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On Wed, Sep 25, 2013 at 5:22 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
On 9/23/13 5:36 PM, Alexander Korotkov wrote:
> In the attached version of patch double finding of ItemPointer during
> insert is avoided. Overhead becomes lower as expected.

Fails cpluspluscheck:

./src/include/access/gin_private.h: In function ‘char*
ginDataPageLeafReadItemPointer(char*, ItemPointer)’:
./src/include/access/gin_private.h:797:2: warning: comparison between
signed and unsigned integer expressions [-Wsign-compare]

Thanks. Fixed in attached version of patch.

------
With best regards,
Alexander Korotkov.
Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [PATCH] pg_upgrade: Split off pg_fatal() from pg_log()
Next
From: Robert Haas
Date:
Subject: Re: FW: REVIEW: Allow formatting in log_line_prefix