[PATCH] pg_upgrade: Split off pg_fatal() from pg_log() - Mailing list pgsql-hackers

From Peter Eisentraut
Subject [PATCH] pg_upgrade: Split off pg_fatal() from pg_log()
Date
Msg-id 1379040642.8575.6.camel@vanquo.pezone.net
Whole thread Raw
Responses Re: [PATCH] pg_upgrade: Split off pg_fatal() from pg_log()
Re: [PATCH] pg_upgrade: Split off pg_fatal() from pg_log()
List pgsql-hackers
The experiences with elog() and ereport() have shown that having one
function that can return or not depending on some log level parameter
isn't a good idea when you want to communicate well with the compiler.
In pg_upgrade, there is a similar case with the pg_log() function.
Since that isn't a public API, I'm proposing to change it and introduce
a separate function pg_fatal() for those cases where the calls don't
return.


Attachment

pgsql-hackers by date:

Previous
From: wangshuo@highgo.com.cn
Date:
Subject: Re: ENABLE/DISABLE CONSTRAINT NAME
Next
From: Peter Eisentraut
Date:
Subject: Re: getting rid of maintainer-check