Postgres Pro
Downloads
Home   >   mailing lists

Re: libpq thread locking during SSL connection start - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: libpq thread locking during SSL connection start
Date
Msg-id 20130801174225.GP2706@tamriel.snowman.net
Whole thread Raw
In response to Re: libpq thread locking during SSL connection start  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: libpq thread locking during SSL connection start
List pgsql-hackers
Tree view 
* Alvaro Herrera (alvherre@2ndquadrant.com) wrote:
> pgsecure_open_client() returns -1 if it can't lock the mutex.  This is a
> problem because the callers are not prepared for that return value.  I
> think it should return PGRES_POLLING_FAILED instead, after setting an
> appropriate error message in conn->errorMessage.

Ah, right, adding it there was a bit of a late addition, tbh.

> initialize_SSL() fails to set an error message.  The return code of -1
> seems fine here.

Right, will improve.
Thanks!
    Stephen

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: libpq thread locking during SSL connection start
Next
From: Dimitri Fontaine
Date:
Subject: Re: Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])