Re: background worker and normal exit - Mailing list pgsql-hackers

From Andres Freund
Subject Re: background worker and normal exit
Date
Msg-id 20130528143111.GF4274@awork2.anarazel.de
Whole thread Raw
In response to Re: background worker and normal exit  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: background worker and normal exit  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 2013-05-28 10:23:46 -0400, Robert Haas wrote:
> On Sun, May 26, 2013 at 6:48 PM, Michael Paquier
> > - set bgw_restart_time to BGW_NEVER_RESTART. and have the bgworler exit with
> > non-0 status code.
> 
> That might be good enough, though.

I suggested that to Fujii at pgcon, and it seems to work for him. But I
think this sucks since you loose support for a restart upon a FATAL or
similar error. And you cannot mark that as something non-fatal in the
log. To this day I laugh about the following oddity in the xorg log:

[    30.087] (II) RADEON(0): RandR 1.2 enabled, ignore the following RandR disabled message.
[    30.088] (--) RandR disabled

I really don't want to go there.

You actually can only return a 1 since everything else will tear down
the whole cluster...

We actually were discussing this recently:
http://archives.postgresql.org/message-id/20130423134833.GD8499%40alap2.anarazel.de

I think a separate return code for "exited gracefully, don't restart"
would be a good idea.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: PostgreSQL Process memory architecture
Next
From: Robert Haas
Date:
Subject: Re: background worker and normal exit