Re: [sepgsql 3/3] Add db_procedure:execute permission checks - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [sepgsql 3/3] Add db_procedure:execute permission checks
Date
Msg-id 20130410234950.GW3751@eldon.alvh.no-ip.org
Whole thread Raw
In response to [sepgsql 3/3] Add db_procedure:execute permission checks  (Kohei KaiGai <kaigai@kaigai.gr.jp>)
Responses Re: [sepgsql 3/3] Add db_procedure:execute permission checks
List pgsql-hackers
Kohei KaiGai wrote:
> This patch adds sepgsql support for permission checks almost
> equivalent to the existing FUNCTION EXECUTE privilege.

While skimming this patch I noticed that you're using
getObjectDescription() as the "audit_name" of objects.  This may be a
bit unstable, for example consider that it's translated if lc_messages
is set to something other than english.  I would suggest that the object
identity as introduced by commit f8348ea32ec8 is a better choice for
this.

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: corrupt pages detected by enabling checksums
Next
From: Michael Paquier
Date:
Subject: Re: SIGHUP not received by custom bgworkers if postmaster is notified