Re: Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing - Mailing list pgsql-hackers

From Marko Kreen
Subject Re: Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing
Date
Msg-id 20120328124626.GA24122@gmail.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing  (Marko Kreen <markokr@gmail.com>)
List pgsql-hackers
On Wed, Mar 28, 2012 at 08:19:37AM -0400, Robert Haas wrote:
> On Tue, Mar 27, 2012 at 10:10 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> > On Wed, Mar 28, 2012 at 5:17 AM, Robert Haas <rhaas@postgresql.org> wrote:
> >> pg_test_timing utility, to measure clock monotonicity and timing cost.
> >
> > When I compiled this, I got a compiler warning. Attached patch
> > silences the warning.
> 
> Unfortunately, that *produces* a warning on my machine.  Normally, I
> think we handle this using INT64_FORMAT, but the fact that it's %10ld
> here and not just %lld makes that awkward.  I guess we maybe need to
> insert some kludgy workaround here - write it into a separate buffer,
> and then blank-pad it, or something like that.

How about:  ".. %10" INT64_FORMAT " .. " ?

-- 
marko



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Improvement of log messages in pg_basebackup
Next
From: Marko Kreen
Date:
Subject: Re: Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing