Re: pgsql: Make pg_dumpall build with the right object files under MSVC. - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Make pg_dumpall build with the right object files under MSVC.
Date
Msg-id 201111281633.pASGXEY29658@momjian.us
Whole thread Raw
In response to pgsql: Make pg_dumpall build with the right object files under MSVC.  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Make pg_dumpall build with the right object files under MSVC.  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-committers
Andrew Dunstan wrote:
> Make pg_dumpall build with the right object files under MSVC.
>
> This fixes a longstanding but up to now benign bug in the way pg_dumpall
> was built. The bug was exposed by recent code adjustments. The Makefile
> does not use $(OBJS) to build pg_dumpall, so this fix removes their source
> files from the pg_dumpall object and adds in the one source file it
> consequently needs.

In summary, for those watching, pg_dump and pg_restore used to share
OBJS, and with my new patch, dumpmem.c is now shared by those and
pg_dumpall.  Seems the MSVC code previously could not handle that case,
which is fixed by this patch.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Backpatch "Use the preferred version of xsubpp."
Next
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Make pg_dumpall build with the right object files under MSVC.