Re: timezone GUC - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: timezone GUC
Date
Msg-id 201109061914.p86JErB12776@momjian.us
Whole thread Raw
In response to Re: timezone GUC  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: timezone GUC
List pgsql-hackers
Tom Lane wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
> > If you have the timezone configured to a non-default value in
> > postgresql.conf, and you comment it out and reload, it says:
> 
> > LOG:  parameter "TimeZone" removed from configuration file, reset to default
> 
> > ...but at least when I tested it, it didn't actually appear to reset
> > it to the default.
> 
> Hm, interesting.  guc-file.l thinks this will fix it in such cases:
> 
>         /* Now we can re-apply the wired-in default */
>         set_config_option(gconf->name, NULL, context, PGC_S_DEFAULT,
>                           GUC_ACTION_SET, true);
> 
> but for variables where the powerup default is "do nothing just yet",
> that, um, does nothing just yet.  The patch I just applied doesn't
> change this behavior.  I suspect that this "re-apply" logic also fails
> for cases where the intended default derives from environment variables.
> 
> Making this work as expected actually looks a bit nasty, because in the
> case where the config file entry was there at system bootup, we never
> did compute a state corresponding to its not being there.  So it's not
> just a matter of rolling back to some prior state.

Was this dealt with?

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: memory-related bugs
Next
From: Alvaro Herrera
Date:
Subject: Re: [COMMITTERS] pgsql: Clean up the #include mess a little.