Re: Removal of useless include references - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Removal of useless include references
Date
Msg-id 201109011451.p81EpfS10698@momjian.us
Whole thread Raw
In response to Re: Removal of useless include references  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Alvaro Herrera wrote:
> Excerpts from Bruce Momjian's message of jue sep 01 11:04:33 -0300 2011:
> > Bruce Momjian wrote:
> 
> > > OK, try #2.  I already had code that removed #if/#else/#endif code in
> > > *.h files for better testing, so I extended that to all *.c files.  This
> > > reduces the size of the diff from 6.6k lines to 4.7k lines but it makes
> > > it much less likely that there will be problems from running
> > > pgrminclude.
> > > 
> > > The current patch is here:
> > > 
> > >     http://momjian.us/expire/pgrminclude.diff
> > > 
> > > I tested the patch on BSD and Linux.
> > 
> > I have re-run the script and applied the result, again tested on BSD and
> > Linux.   I will monitor the buildfarm for possible failures.
> 
> I think anything of this sort should be tested on Windows too.

Agreed, but we have so many Windows configurations I figured I would let
the buildfarm test them, no?

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Removal of useless include references
Next
From: Bruce Momjian
Date:
Subject: Re: Removal of useless include references