Re: pgsql: Properly call strerror() in thread test; add comments. - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Properly call strerror() in thread test; add comments.
Date
Msg-id 201108221447.p7MElM124510@momjian.us
Whole thread Raw
In response to Re: pgsql: Properly call strerror() in thread test; add comments.  (Peter Geoghegan <peter@2ndquadrant.com>)
List pgsql-committers
Peter Geoghegan wrote:
> Why have you removed the GetLastError() call? MSDN says that "The
> return value is the calling thread's last-error code".

True, but we check it also after all the threads have completed setting
their error values.  I removed it because Unix does not have such a
check and it seemed logical to do the check only after we were done.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

pgsql-committers by date:

Previous
From: andrewsn@pgfoundry.org (User Andrewsn)
Date:
Subject: ip4r - ip4r: missing file.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix handling of extension membership when filling in a shell ope