Re: pg_restore silently chokes on object comments/descriptions ending in a backslash - Mailing list pgsql-bugs

From Julian Mehnle
Subject Re: pg_restore silently chokes on object comments/descriptions ending in a backslash
Date
Msg-id 201107270402.02561.julian@mehnle.net
Whole thread Raw
In response to Re: pg_restore silently chokes on object comments/descriptions ending in a backslash  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_restore silently chokes on object comments/descriptions ending in a backslash  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
I'm subscribed to the pgsql-bugs list, so no need to CC me. :-)

Tom Lane wrote:

> Reproduced here against HEAD.  The problem seems to be that
> pg_backup_db.c's _sendSQLLine() contains a mini SQL lexer that is not
> cognizant of standard_conforming_strings.

Oh, right, I forgot to mention I have standard_conforming_strings enabled.=
=20=20
However, I understand that is to become the new default anyway.

> Not sure about a simple fix,=20
> and I rather wonder if we shouldn't try to remove that code entirely
> instead of "fix" it.

What would "removing that code entirely" mean?

> As a temporary workaround, the SQL text file that pg_restore produces
> by default seems to be valid, so you could pipe that into psql.

Hmm, right.  So at least my existing dumps aren't useless.  Thanks.

-Julian

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_restore silently chokes on object comments/descriptions ending in a backslash
Next
From: Tom Lane
Date:
Subject: Re: pg_restore silently chokes on object comments/descriptions ending in a backslash