Re: spurious use of %m format in pg_upgrade - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: spurious use of %m format in pg_upgrade
Date
Msg-id 201107121507.p6CF70113152@momjian.us
Whole thread Raw
In response to spurious use of %m format in pg_upgrade  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Peter Eisentraut wrote:
> pg_upgrade's pg_scandir_internal() makes use of the non-standard %m
> format:
> 
>     pg_log(PG_FATAL, "could not open directory \"%s\": %m\n", dirname);
> 
> Is this an oversight, or is there an undocumented assumption that this
> code will only be used on platforms where %m works?
> 
> (Which platforms don't have scandir() anyway?)

Yes, surely an oversight, and I see it has been removed --- good.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: remove README.mb.jp and README.mb.big5?
Next
From: "Joshua D. Drake"
Date:
Subject: Re: Full GUID support