Use of access(X_OK) check in pg_upgrade - Mailing list pgsql-hackers

From Bruce Momjian
Subject Use of access(X_OK) check in pg_upgrade
Date
Msg-id 201105181541.p4IFfpL11199@momjian.us
Whole thread Raw
Responses Re: Use of access(X_OK) check in pg_upgrade  (Magnus Hagander <magnus@hagander.net>)
Re: Use of access(X_OK) check in pg_upgrade  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
I broke the Win32 build members by using access(X_OK) in pg_upgrade.  I
have a fix for this but looking at pg_upgrade's exec.c, I see for
Win32:
    if ((buf.st_mode & S_IXUSR) == 0)

I am confused why Windows supports S_IXUSR but not X_OK.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +


pgsql-hackers by date:

Previous
From: Stefan Kaltenbrunner
Date:
Subject: Re: deprecating contrib for PGXN
Next
From: Noah Misch
Date:
Subject: Re: switch UNLOGGED to LOGGED