Re: Error code for "terminating connection due to conflict with recovery" - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: Error code for "terminating connection due to conflict with recovery"
Date
Msg-id 20110115.005303.397930884272255413.t-ishii@sraoss.co.jp
Whole thread Raw
In response to Re: Error code for "terminating connection due to conflict with recovery"  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Error code for "terminating connection due to conflict with recovery"  (Robert Haas <robertmhaas@gmail.com>)
Re: Error code for "terminating connection due to conflict with recovery"  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> Review:
> 
> The only possible point of concern I see here is the naming of the C
> identifier.  Everything else in class 40 uses ERRCODE_T_R_whatever,
> with T_R standing for transaction rollback.  It's not obvious to me
> that that convention has any real value, but perhaps we ought to
> follow it here for the sake of consistency?

Yeah. Actually at first I used "T_R" convention. After a few seconds
thought, I realized that "T_R" is not appropreate by the same reason
you feel. Possible other argument might be "Terminating connection
always involves transaction rollback. So using T_R is ok". I'm not
sure this argument is reasonable enough though.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: kill -KILL: What happens?
Next
From: "Kevin Grittner"
Date:
Subject: Re: kill -KILL: What happens?