Re: [sqlsmith] Missing CHECK_FOR_INTERRUPTS in tsquery_rewrite - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [sqlsmith] Missing CHECK_FOR_INTERRUPTS in tsquery_rewrite
Date
Msg-id 20109.1477849229@sss.pgh.pa.us
Whole thread Raw
In response to Re: [sqlsmith] Missing CHECK_FOR_INTERRUPTS in tsquery_rewrite  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I wrote:
> Also, I think this is outright *wrong* for phrase search --- dropping some
> of the child nodes without any other adjustment isn't valid is it?

After further digging, it seems there's no bug because the tree is
originally binary and QTNTernary won't try to flatten OP_PHRASE nodes.
So we can't actually get to this logic for such nodes.  But seems like
an Assert for that wouldn't be a bad thing.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [sqlsmith] Missing CHECK_FOR_INTERRUPTS in tsquery_rewrite
Next
From: Tomas Vondra
Date:
Subject: Re: Speed up Clog Access by increasing CLOG buffers