Re: duplicate connection failure messages - Mailing list pgsql-hackers

Alvaro Herrera wrote:
> Excerpts from Bruce Momjian's message of nov 24 19:04:30 -0300 2010:
> > Bruce Momjian wrote:
>
> > > OK, we will not call inet_ntop() at all.  I moved the CIDR part of
> > > adt/inet_net_ntop.c into adt/inet_cidr_ntop.c, and moved the remaining
> > > "net" part to /port/inet_net_ntop.c.
>
> > Applied.
>
> This broke dugong in the ecpg tests.

I stopped checking the build page after a few hours, but I see the
failure now.

I have reviewed the libpq Makefile and I believe I am now properly added
port/inet_net_ntop.c.  I improved the comments as well.

Patch attached and applied.  Thansk for the heads-up.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +
diff --git a/src/interfaces/libpq/Makefile b/src/interfaces/libpq/Makefile
index b327ee5..74ae79a 100644
*** /tmp/mhssze_Makefile    Wed Nov 24 21:42:22 2010
--- src/interfaces/libpq/Makefile    Wed Nov 24 21:04:00 2010
*************** endif
*** 27,39 ****
  # Need to recompile any libpgport object files because we need these
  # object files to use the same compile flags as libpq.  If we used
  # the object files from libpgport, this would not be true on all
! # platforms.
  LIBS := $(LIBS:-lpgport=)

  OBJS=    fe-auth.o fe-connect.o fe-exec.o fe-misc.o fe-print.o fe-lobj.o \
      fe-protocol2.o fe-protocol3.o pqexpbuffer.o pqsignal.o fe-secure.o \
      libpq-events.o \
!     md5.o ip.o wchar.o encnames.o noblock.o pgstrcasecmp.o thread.o \
      $(filter crypt.o getaddrinfo.o inet_aton.o open.o snprintf.o strerror.o strlcpy.o win32error.o, $(LIBOBJS))

  ifeq ($(PORTNAME), cygwin)
--- 27,40 ----
  # Need to recompile any libpgport object files because we need these
  # object files to use the same compile flags as libpq.  If we used
  # the object files from libpgport, this would not be true on all
! # platforms.  We filter some object files so we only use object
! # files configure says we need.
  LIBS := $(LIBS:-lpgport=)

  OBJS=    fe-auth.o fe-connect.o fe-exec.o fe-misc.o fe-print.o fe-lobj.o \
      fe-protocol2.o fe-protocol3.o pqexpbuffer.o pqsignal.o fe-secure.o \
      libpq-events.o \
!     md5.o ip.o wchar.o encnames.o inet_net_ntop.o noblock.o pgstrcasecmp.o thread.o \
      $(filter crypt.o getaddrinfo.o inet_aton.o open.o snprintf.o strerror.o strlcpy.o win32error.o, $(LIBOBJS))

  ifeq ($(PORTNAME), cygwin)
*************** backend_src = $(top_srcdir)/src/backend
*** 80,86 ****
  # For port modules, this only happens if configure decides the module
  # is needed (see filter hack in OBJS, above).

! crypt.c getaddrinfo.c inet_aton.c noblock.c open.c pgstrcasecmp.c snprintf.c strerror.c strlcpy.c thread.c
win32error.cpgsleep.c: % : $(top_srcdir)/src/port/% 
      rm -f $@ && $(LN_S) $< .

  md5.c ip.c: % : $(backend_src)/libpq/%
--- 81,87 ----
  # For port modules, this only happens if configure decides the module
  # is needed (see filter hack in OBJS, above).

! crypt.c getaddrinfo.c inet_aton.c inet_net_ntop.c noblock.c open.c pgstrcasecmp.c snprintf.c strerror.c strlcpy.c
thread.cwin32error.c pgsleep.c: % : $(top_srcdir)/src/port/% 
      rm -f $@ && $(LN_S) $< .

  md5.c ip.c: % : $(backend_src)/libpq/%