pgsql: Revert patch to coerce 'unknown' type parameters in the backend. - Mailing list pgsql-committers

From heikki@postgresql.org (Heikki Linnakangas)
Subject pgsql: Revert patch to coerce 'unknown' type parameters in the backend.
Date
Msg-id 20100819165443.A57E47541D7@cvs.postgresql.org
Whole thread Raw
List pgsql-committers
Log Message:
-----------
Revert patch to coerce 'unknown' type parameters in the backend. As Tom
pointed out, it would need a 2nd pass after the whole query is processed to
correctly check that an unknown Param is coerced to the same target type
everywhere. Adding the 2nd pass would add a lot more code, which doesn't
seem worth the risk given that there isn't much of a use case for passing
unknown Params in the first place. The code would work without that check,
but it might be confusing and the behavior would be different from the
varparams case.

Instead, just coerce all unknown params in a PL/pgSQL USING clause to text.
That's simple, and is usually what users expect.

Revert the patch in CVS HEAD and master, and backpatch the new solution to
8.4. Unlike the previous solution, this applies easily to 8.4 too.

Modified Files:
--------------
    pgsql/src/backend/parser:
        parse_param.c (r2.5 -> r2.6)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_param.c?r1=2.5&r2=2.6)
    pgsql/src/pl/plpgsql/src:
        pl_exec.c (r1.263 -> r1.264)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_exec.c?r1=1.263&r2=1.264)

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Allocate local buffers in a context of their own, rather than
Next
From: heikki@postgresql.org (Heikki Linnakangas)
Date:
Subject: pgsql: Revert patch to coerce 'unknown' type parameters in the backend.