Re: [COMMITTERS] pgsql: Add support for TCP keepalives on Windows, both for backend and - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [COMMITTERS] pgsql: Add support for TCP keepalives on Windows, both for backend and
Date
Msg-id 201007102023.o6AKNHb09290@momjian.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add support for TCP keepalives on Windows, both for backend and  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Re: [COMMITTERS] pgsql: Add support for TCP keepalives on Windows, both for backend and
Re: Re: [COMMITTERS] pgsql: Add support for TCP keepalives on Windows, both for backend and
List pgsql-hackers
Magnus Hagander wrote:
> > An easy approximation would be to make the code #ifdef SIO_KEEPALIVE_VALS.
> > That would fail if the mingw guys decide to provide the #define without
> > adding the struct at the same time, but that seems moderately unlikely.
>
> Seems reasonable. I'll go do something along that line and verify that
> it actually works :-)
>
> That laves the questions of docs - right now the docs just say it
> works on windows. I guess we need to add some kind of disclaimer
> around that, but the fact is that for 99+% of our windows users it
> will work - since they use the binaries, and the binaries are built
> with the full api - so we shouldn't make it *too* prominent..

Wow, how would they know if the binaries are MinGW compiled?  Does it
show in version()?

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + None of us is going to be here forever. +

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: ALTER TABLE SET STATISTICS requires AccessExclusiveLock
Next
From: Tom Lane
Date:
Subject: Re: gSoC - ADD MERGE COMMAND - code patch submission