Re: pg_trgm - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: pg_trgm
Date
Msg-id 20100528.094014.35036383.t-ishii@sraoss.co.jp
Whole thread Raw
In response to Re: pg_trgm  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_trgm
List pgsql-hackers
> > Problem with pg_trgm is, it uses isascii() etc. to recognize a letter,
> > which will skip any non ASCII range character in C locale.
> 
> The only place I see that is in those ISPRINTABLE macros, which are only
> used in show_trgm(), which is just a debugging function.  It could stand
> to be improved but it doesn't seem exactly critical.

Really?

similarity -> generate_trgm -> find_word -> iswordchr -> t_isalpha -> isalpha

if locale is C and USE_WIDE_UPPER_LOWER defined which is the case in
most modern OSs.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp


pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: List traffic
Next
From: Tom Lane
Date:
Subject: Re: List traffic