pgsql: Add code to InternalIpcMemoryCreate() to handle the case where - Mailing list pgsql-committers

From tgl@postgresql.org (Tom Lane)
Subject pgsql: Add code to InternalIpcMemoryCreate() to handle the case where
Date
Msg-id 20100501224630.4BD8C7541D2@cvs.postgresql.org
Whole thread Raw
List pgsql-committers
Log Message:
-----------
Add code to InternalIpcMemoryCreate() to handle the case where shmget()
returns EINVAL for an existing shared memory segment.  Although it's not
terribly sensible, that behavior does meet the POSIX spec because EINVAL
is the appropriate error code when the existing segment is smaller than the
requested size, and the spec explicitly disclaims any particular ordering of
error checks.  Moreover, it does in fact happen on OS X and probably other
BSD-derived kernels.  (We were able to talk NetBSD into changing their code,
but purging that behavior from the wild completely seems unlikely to happen.)
We need to distinguish collision with a pre-existing segment from invalid size
request in order to behave sensibly, so it's worth some extra code here to get
it right.  Per report from Gavin Kistner and subsequent investigation.

Back-patch to all supported versions, since any of them could get used
with a kernel having the debatable behavior.

Modified Files:
--------------
    pgsql/src/backend/port:
        sysv_shmem.c (r1.55 -> r1.56)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/port/sysv_shmem.c?r1=1.55&r2=1.56)

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Install hack workaround for failure of 'make all' in VPATH
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Add code to InternalIpcMemoryCreate() to handle the case where