Re: Compile fail, alpha5 & gcc 4.3.3 in elog.c - Mailing list pgsql-hackers

From Takahiro Itagaki
Subject Re: Compile fail, alpha5 & gcc 4.3.3 in elog.c
Date
Msg-id 20100406142933.9C57.52131E4D@oss.ntt.co.jp
Whole thread Raw
In response to Re: Compile fail, alpha5 & gcc 4.3.3 in elog.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Compile fail, alpha5 & gcc 4.3.3 in elog.c  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> wrote:

> > -    cygwin_conv_to_full_win32_path(cmdLine, buf);
> > +    cygwin_conv_path(CCP_POSIX_TO_WIN_A, cmdLine, buf, sizeof(buf));
> 
> Buildfarm member brown_bat didn't like this.  Seeing that that's the
> *only* active cygwin buildfarm member, that's not a good percentage.

Hmmm, but avoiding deprecated APIs would be good on the lastest cygwin.
How about checking the version with #ifdef?
#ifdef __CYGWIN__    /* need to convert to windows path */
+#if CYGWIN_VERSION_DLL_MAJOR >= 1007    cygwin_conv_path(CCP_POSIX_TO_WIN_A, cmdLine, buf, sizeof(buf));
+#else
+    cygwin_conv_to_full_win32_path(cmdLine, buf);
+#endif    strcpy(cmdLine, buf);#endif

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center




pgsql-hackers by date:

Previous
From: Petr Jelinek
Date:
Subject: Re: Proposal: Add JSON support
Next
From: Josh Berkus
Date:
Subject: Prepared query parsing much slower in 9.0?