Re: libpq-example.html needs to use <> includes - Mailing list pgsql-docs

From Bruce Momjian
Subject Re: libpq-example.html needs to use <> includes
Date
Msg-id 201002270341.o1R3faR28473@momjian.us
Whole thread Raw
In response to libpq-example.html needs to use <> includes  (Josh Berkus <josh@agliodbs.com>)
List pgsql-docs
Josh Berkus wrote:
> All,
>
> The libpq-example is using local includes for libpq-fe, instead of
> library includes:
>
> #include "libpq-fe.h"
>
> I can't think of a single good reason for this, is there one?

Agreed, fixed with the attached, applied patch.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do
  + If your life is a hard drive, Christ can be your backup. +
Index: doc/src/sgml/libpq.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/libpq.sgml,v
retrieving revision 1.302
diff -c -c -r1.302 libpq.sgml
*** doc/src/sgml/libpq.sgml    24 Feb 2010 15:54:31 -0000    1.302
--- doc/src/sgml/libpq.sgml    27 Feb 2010 03:40:36 -0000
***************
*** 7010,7016 ****
   */
  #include <stdio.h>
  #include <stdlib.h>
! #include "libpq-fe.h"

  static void
  exit_nicely(PGconn *conn)
--- 7010,7016 ----
   */
  #include <stdio.h>
  #include <stdlib.h>
! #include <libpq-fe.h>

  static void
  exit_nicely(PGconn *conn)
***************
*** 7158,7164 ****
  #include <string.h>
  #include <errno.h>
  #include <sys/time.h>
! #include "libpq-fe.h"

  static void
  exit_nicely(PGconn *conn)
--- 7158,7164 ----
  #include <string.h>
  #include <errno.h>
  #include <sys/time.h>
! #include <libpq-fe.h>

  static void
  exit_nicely(PGconn *conn)
***************
*** 7296,7302 ****
  #include <stdlib.h>
  #include <string.h>
  #include <sys/types.h>
! #include "libpq-fe.h"

  /* for ntohl/htonl */
  #include <netinet/in.h>
--- 7296,7302 ----
  #include <stdlib.h>
  #include <string.h>
  #include <sys/types.h>
! #include <libpq-fe.h>

  /* for ntohl/htonl */
  #include <netinet/in.h>

pgsql-docs by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: CREATE FUNCTION reference page's Notes section is getting out of hand
Next
From: Bruce Momjian
Date:
Subject: Locale example