Re: TRUNCATE+COPY optimization and --jobs=1 in pg_restore - Mailing list pgsql-hackers

From Takahiro Itagaki
Subject Re: TRUNCATE+COPY optimization and --jobs=1 in pg_restore
Date
Msg-id 20100210131107.47ED.52131E4D@oss.ntt.co.jp
Whole thread Raw
In response to Re: TRUNCATE+COPY optimization and --jobs=1 in pg_restore  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: TRUNCATE+COPY optimization and --jobs=1 in pg_restore
List pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp> writes:
> > We have an optimization to bulkload date in pg_restore, but the code
> > only works in parallel restore (--jobs >= 2). Why don't we do the
> > same optimization in the serial restore (--jobs = 1) ?
>
> The code is only trying to substitute for something you can't have
> in parallel restore, ie --single-transaction.

Yeah, the comment says so. But it does not necessarily mean that
we cannot optimize the copy also in non-single-transaction restore.

The attached patch improve the judgment condition,
I'll add it to the next commit-fest.

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center


Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Some belated patch review for "Buffers" explain analyze patch
Next
From: Andrew Dunstan
Date:
Subject: Re: TRUNCATE+COPY optimization and --jobs=1 in pg_restore