Re: Fix auto-prepare #2 - Mailing list pgsql-hackers

From Michael Meskes
Subject Re: Fix auto-prepare #2
Date
Msg-id 20100122141844.GA30579@feivel.credativ.lan
Whole thread Raw
In response to Re: Fix auto-prepare #2  (Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>)
List pgsql-hackers
Takahiro-san,

> Good. I think the patch is ready to commit.

Thanks for reviewing it. I just committed the patch.

> A comment for committer (Michael?) :
> I was cofused by the AddStmtToCache's 2nd argument "char *stmtID"
> because it doesn't have a const. Should it be "const char *" ?
> If the argument has a const, callers assume that they can pass
> a not-strdup'ed string as the argument.

Valid point, I can see no reason for not making this a "const char *". So let's
try.

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ 179140304, AIM/Yahoo/Skype michaelmeskes, Jabber meskes@jabber.org
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: commit fests (was Re: primary key error message)
Next
From: Greg Stark
Date:
Subject: Re: About "Our CLUSTER implementation is pessimal" patch