Re: plpgsql: open for execute - add USING clause - Mailing list pgsql-hackers

From Takahiro Itagaki
Subject Re: plpgsql: open for execute - add USING clause
Date
Msg-id 20100114103421.9A0E.52131E4D@oss.ntt.co.jp
Whole thread Raw
In response to Re: plpgsql: open for execute - add USING clause  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: plpgsql: open for execute - add USING clause  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-hackers
Pavel Stehule <pavel.stehule@gmail.com> wrote:

> ok, I accept all comments.
> revised version are attached.

Good. This patch is ready to commit. I'll do it soon if no objections.

BTW, I found inconsistent parameter dumps in the codes. Some of them
add '$', but others does not. Are they intentional? Or, should we
adjust them to use one of the formats?

[pl_funcs.c]
dump_dynexecute()
dump_raise()        printf("    parameter %d: ", i++);
dump_dynfors()
dump_open()
dump_return_query()        printf("    parameter $%d: ", i++);


Regards,
---
Takahiro Itagaki
NTT Open Source Software Center




pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: last CommitFest coming up in just under 24 hours
Next
From: KaiGai Kohei
Date:
Subject: Re: [PATCH] remove redundant ownership checks