Re: pgsql: Simplify validate_exec() by using access(2) to check file - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Simplify validate_exec() by using access(2) to check file
Date
Msg-id 201001140430.o0E4UuN10021@momjian.us
Whole thread Raw
In response to pgsql: Simplify validate_exec() by using access(2) to check file  (tgl@postgresql.org (Tom Lane))
Responses Re: pgsql: Simplify validate_exec() by using access(2) to check file
List pgsql-committers
Tom Lane wrote:
> Log Message:
> -----------
> Simplify validate_exec() by using access(2) to check file permissions,
> rather than trying to implement the equivalent logic by hand.  The motivation
> for the original coding appears to have been to check with the effective uid's
> permissions not the real uid's; but there is no longer any difference, because
> we don't run the postmaster setuid (indeed, main.c enforces that they're the
> same).  Using access() means we will get it right in situations the original
> coding failed to handle, such as ACL-based permissions.  Besides it's a lot
> shorter, cleaner, and more thread-safe.  Per bug #5275 from James Bellinger.

Are there any outside code modifications now that this is thread-safe?
I can't find any myself.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Simplify validate_exec() by using access(2) to check file
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Simplify validate_exec() by using access(2) to check file