Re: Setting oom_adj on linux? - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Setting oom_adj on linux?
Date
Msg-id 201001081453.o08Erxt01807@momjian.us
Whole thread Raw
In response to Re: Setting oom_adj on linux?  (Alex Hunsaker <badalex@gmail.com>)
Responses Re: Setting oom_adj on linux?  (Alex Hunsaker <badalex@gmail.com>)
List pgsql-hackers
Alex Hunsaker wrote:
> On Thu, Jan 7, 2010 at 20:26, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Alex Hunsaker <badalex@gmail.com> writes:
> 
> > We can either drop this in core (with a lot of #ifdef LINUX added)
> 
> Any thoughts on doing something like (in fork_process.c)
> 
> #ifdef LINUX
> void oom_adjust()
> {
> ...
> }
> #else
> void oom_adjust() {}
> #endif
> 
> So there is only one #ifdef?  It still leaves the ugly calls to the function...

The usual solution for this kind of thing is:
#ifdef LINUX#define OOM_ADJUST oom_adjust()#else#define OOM_ADJUST do {} while (0)#endif

so there is no call or dummy function and you reference it in the code
as:
OOM_ADJUST;

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: Serializable implementation
Next
From: Robert Haas
Date:
Subject: Re: Serializable Isolation without blocking