Re: [PATCH] Provide rowcount for utility SELECTs - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH] Provide rowcount for utility SELECTs
Date
Msg-id 20091229133551.GB4569@alvh.no-ip.org
Whole thread Raw
In response to Re: [PATCH] Provide rowcount for utility SELECTs  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Provide rowcount for utility SELECTs  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane escribió:
> Boszormenyi Zoltan <zb@cybertec.at> writes:
> > Tom Lane �rta:
> >> It's more the possibility of doing strcmp(tag, "SELECT") on the command
> 
> > Actually it's strncmp(tag, "SELECT ", 7), so when you mix old server
> > with new clients or new server with old client, it will just work as
> > before, i.e. return "".
> 
> Are you deliberately ignoring the point?  We have no way to know whether
> there is any client-side code that's doing a simple check for SELECT
> command tag, but it's certainly possible.  The fact that it wouldn't be
> hard to fix does not mean that it wouldn't be broken.

But it would be broken in very obvious ways, no?  It's not like it would
be silently broken and thus escape testing ...

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Add subdirectory support for DATA/DOCS with PGXS
Next
From: Andres Freund
Date:
Subject: Re: parse tree to XML format