Verifying variable names in pgbench - Mailing list pgsql-hackers

From Takahiro Itagaki
Subject Verifying variable names in pgbench
Date
Msg-id 20091228123859.92F8.52131E4D@oss.ntt.co.jp
Whole thread Raw
List pgsql-hackers
We can define variables with any names in pgbench,
but only can refer them with names that consist of [A-Za-z0-9_]+ .
It could cause confusion discussed here:
http://archives.postgresql.org/message-id/4B272833.8080500@2ndquadrant.com

The attached patch verifies variable names at definition.
    $ pgbench -D var:name=value
    (global): invalid variable name 'var:name'

It would help users to determine why their custom scripts failed
when they misuse "\setXXX :varname" (the colon should be removed).

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Small locking bugs in hs
Next
From: James William Pye
Date:
Subject: Re: Additional SPI functions