Re: Rename StrNCpy to avoid conflictions on win32 - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Rename StrNCpy to avoid conflictions on win32
Date
Msg-id 200909181334.n8IDYcd19141@momjian.us
Whole thread Raw
In response to Re: Rename StrNCpy to avoid conflictions on win32  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Peter Eisentraut wrote:
> On Mon, 2009-09-07 at 11:36 +0200, Magnus Hagander wrote:
> > On Mon, Sep 7, 2009 at 04:40, Itagaki
> > Takahiro<itagaki.takahiro@oss.ntt.co.jp> wrote:
> > > There might be some places to replace it to strlcpy() instead.
> > 
> > Can't comment on that without looking at the code, but it wouldn't surprise me.
> 
> There are some performance tradeoffs between these variants, and we
> already did change all (most?) of the not performance-critical calls to
> strlcpy a while ago.

Of all the macro names we use, I would have bet StrNCpy() was the last
one that would have conflicted with anything.  :-O  Did they copy it
from our code?

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Merlin Moncure
Date:
Subject: Re: happy birthday Tom Lane ...
Next
From: Robert Haas
Date:
Subject: Re: happy birthday Tom Lane ...