Re: Patch: update Bonjour support to the newer non-deprecated API - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Patch: update Bonjour support to the newer non-deprecated API
Date
Msg-id 20090907182030.GO8894@alvh.no-ip.org
Whole thread Raw
In response to Re: Patch: update Bonjour support to the newer non-deprecated API  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Patch: update Bonjour support to the newer non-deprecated API
List pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > The source is here:
> > http://avahi.sourcearchive.com/documentation/0.6.25-1ubuntu1/avahi-compat-libdns__sd_2compat_8c-source.html
> 
> After reading that code, I am content to remain forcibly non compatible
> with it.  If we relied on this it would inject threading into the
> postmaster, which was precisely the thing that got the previous Avahi
> patch rejected last year :-(

Should we inject some sort of compile-time rejection of the
compatibility API?  Like, say

#ifdef AVAHI_SERVICE_COOKIE
#error The Avahi implementation is incompatible
#endif

inside some #ifdef BONJOUR block?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Patch: update Bonjour support to the newer non-deprecated API
Next
From: Robert Creager
Date:
Subject: Re: [Pgbuildfarm-members] Snow Leopard bison/flex build problem