Re: [COMMITTERS] pgsql: Move processing of startup-packet switches and GUC settings into - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [COMMITTERS] pgsql: Move processing of startup-packet switches and GUC settings into
Date
Msg-id 20090901134903.GA7243@alvh.no-ip.org
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Move processing of startup-packet switches and GUC settings into
List pgsql-hackers
Tom Lane wrote:
> Log Message:
> -----------
> Move processing of startup-packet switches and GUC settings into InitPostgres,
> to fix the problem that SetClientEncoding needs to be done before
> InitializeClientEncoding, as reported by Zdenek Kotala.  We get at least
> the small consolation of being able to remove the bizarre API detail that
> had InitPostgres returning whether user is a superuser.

So, I think InitPostgres API could be deuglified a bit more by having
the launcher pass the database name instead of the OID.  There's the
small race condition that the launcher could pass a database name and
have it be renamed before the worker starts, but I think it's small
enough to not matter much (note that it's already true that the launcher
could pass a database OID and have it be dropped before the worker
starts).  Is anyone opposed to doing that change?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Werner Echezuria
Date:
Subject: Re: Bison crashes postgresql
Next
From: Tom Lane
Date:
Subject: Re: remove flatfiles.c