Re: hba load error and silent mode - Mailing list pgsql-hackers

From Joshua Tolley
Subject Re: hba load error and silent mode
Date
Msg-id 20090824142138.GZ31216@eddie
Whole thread Raw
In response to Re: hba load error and silent mode  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On Mon, Aug 24, 2009 at 02:57:02PM +0200, Magnus Hagander wrote:
> On Mon, Aug 24, 2009 at 14:39, Andrew Dunstan<andrew@dunslane.net> wrote:
> >
> > Last night I had to deal with a puzzled user of version 8.4  who found
> > postgres refused to start but didn't log any error.  It turned out that
> > there was an error in the pg_hba.conf file, and the client was running in
> > silent mode (the SUSE default).
> >
> > This seems like a bug, and it's certainly not very postgres-like behaviour.
> >
> > Can we move the call to hba_load() in postmaster.c down a bit so it occurs
> > after the SysLogger is set up? ISTM we really need an absolute minimum of
> > code between the call to pmdaemonize() and SysLogger_Start().
>
> I can see other reasons that this would be good, so +1 from me unless
> there is any specific reason we can't start it earlier.

+1 from me, too, under the same condition.  Since logging in really
interesting ways depends on a separate process, any logging before then will
be "abnormal", and any logs we create will probably show up in a relatively
unexpected place. The Principle of Least Surprise suggests we minimize that
possibility.

--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: hba load error and silent mode
Next
From: Tom Lane
Date:
Subject: Re: hba load error and silent mode