Re: [PATCH 5/6] psql: print_aligned_text uses table formatting - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH 5/6] psql: print_aligned_text uses table formatting
Date
Msg-id 20090823222912.GB5287@alvh.no-ip.org
Whole thread Raw
In response to Re: [PATCH 5/6] psql: print_aligned_text uses table formatting  (Roger Leigh <rleigh@codelibre.net>)
List pgsql-hackers
Roger Leigh wrote:
> On Sun, Aug 23, 2009 at 11:47:02AM -0400, Alvaro Herrera wrote:

> > Wouldn't it be better to do a single fprintf call here instead of
> > fputc + fputs?
> 
> It's certainly possible to change it; the above might be slightly more
> efficient than a call to fprintf since you skip parsing the format
> string, but otherwise I have no real preference for one over the
> other.

There are already other fprintf calls in the same function -- I wouldn't
worry too much about some hypothetical performance gain.  Let's keep
things simple and readable.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Grzegorz Jaskiewicz
Date:
Subject: Re: clang's static checker report.
Next
From: Alvaro Herrera
Date:
Subject: Re: Unicode UTF-8 table formatting for psql text output