schemapg.h - Mailing list pgsql-hackers

From Alvaro Herrera
Subject schemapg.h
Date
Msg-id 20090812221628.GN5721@alvh.no-ip.org
Whole thread Raw
Responses Re: schemapg.h  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I think having schemapg.h be autogenerated is a good idea, so I stripped
that from Robert Haas' patch.  Here's the result.  This should be
relatively uncontroversial since, well, the controversial stuff has been
stripped.  The one problem is that it introduces more complex code than
it removes dull declarations.

Ideally this would serve as a basis upon which the rest of the generated
stuff is built.  I think it would be good to have a module that contains
common code.  In particular we could move process_input_file() to it,
and pass function refs for each subblock.  That way each program could
be relatively short, and the regexes that parse the files would all be
in a single place.

Thoughts?

--
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: surprising trigger/foreign key interaction
Next
From: Alvaro Herrera
Date:
Subject: Re: COPY speedup