Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY) - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)
Date
Msg-id 200908112306.n7BN64414877@momjian.us
Whole thread Raw
In response to Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > Andrew Dunstan escribi�:
> >> Here's the extract attached.  I replace tabs with a literal '\t' so
> >> I could see what it was doing. I can't make much head or tail of it
> >> either.
> 
> > pgindent uses entab/detab, which counts spaces and replaces them with
> > tabs.  It is wildly undocumented.  See src/tools/entab
> 
> What surprises me is that it seems to be changing lines that have been
> there for quite some time.  Bruce, have you been changing pgindent
> underneath us?

Not unless I am CVS committing without showing anyone.  ;-)

These are the only commits I see recently, which are harmless:
revision 1.101date: 2009/06/11 22:21:44;  author: momjian;  state: Exp;  lines: +7 -2Document struct/union problem with
pgindent.----------------------------revision1.100date: 2008/11/03 15:56:47;  author: momjian;  state: Exp;  lines: +2
-2Smallshell syntax improvement.----------------------------revision 1.99date: 2008/04/16 21:03:08;  author: momjian;
state:Exp;  lines: +2 -2Ignore blank lines in typedef file.----------------------------revision 1.98date: 2008/01/16
20:13:44; author: momjian;  state: Exp;  lines: +2 -2Improve usage message for
pgindent.----------------------------revision1.97date: 2007/12/21 14:20:36;  author: momjian;  state: Exp;  lines:
+11-2008Modifypgindent to use an external typedefs file rather than includedlist.
 

and entab is similarly unchanged:
revision 1.18date: 2007/02/08 11:10:27;  author: petere;  state: Exp;  lines: +2 -2Normalize fgets() calls to use
sizeof()for calculating the buffer sizewhere possible, and fix some sites that apparently thought that fgets()will
overwritethe buffer by one byte.Also add some strlcpy() to eliminate some weird memory handling.
 

I am stumped, but can keep researching.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Paul Matthews
Date:
Subject: Re: Quick pointer required re indexing geometry
Next
From: Tom Lane
Date:
Subject: WIP: getting rid of the pg_database flat file