Re: [PATCH] backend: compare word-at-a-time in bcTruelen - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: [PATCH] backend: compare word-at-a-time in bcTruelen
Date
Msg-id 20090624111111.GE20436@tamriel.snowman.net
Whole thread Raw
In response to Re: [PATCH] backend: compare word-at-a-time in bcTruelen  (Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>)
Responses Re: [PATCH] backend: compare word-at-a-time in bcTruelen  (Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>)
Re: [PATCH] backend: compare word-at-a-time in bcTruelen  (Jeremy Kerr <jk@ozlabs.org>)
List pgsql-hackers
* Stefan Kaltenbrunner (stefan@kaltenbrunner.cc) wrote:
> FWIW: I'm able to measure an even more significant improvement of around
> 10%:

What would be really useful would be "best case" and "worst case"
scenarios.  Ideally, with profile information for this specific function
(in addition to full benchmark runs since those can show minimal
performance improvments due to other constraints, locking, etc).

Have you tried pulling this function out and running tests with all
alignment possibilities to see how it compares to the original?  There's
only so many options and showing that this change always improves
performance, or at least doesn't degrade it in the worst case, would
certainly go a long way towards getting it accepted..
Thanks,
    Stephen

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: dblink for 8.4 should work without user-mappings
Next
From: Stefan Kaltenbrunner
Date:
Subject: Re: [PATCH] backend: compare word-at-a-time in bcTruelen