Re: [PATCH v2] Add bit operations util header - Mailing list pgsql-hackers

From Jeremy Kerr
Subject Re: [PATCH v2] Add bit operations util header
Date
Msg-id 200906032127.16906.jk@ozlabs.org
Whole thread Raw
In response to Re: [PATCH v2] Add bit operations util header  (Florian Weimer <fweimer@bfk.de>)
Responses Re: [PATCH v2] Add bit operations util header  (Florian Weimer <fweimer@bfk.de>)
List pgsql-hackers
Florian,

> > +#if defined(__GNUC__) && \
> > +    (defined(__ppc__) || defined(__powerpc__) || \
> > +     defined(__ppc64__) || defined (__powerpc64__))
>
> If you require GCC anyway, you can use __builtin_clz instead.
> (It's been available since GCC 4.1 at least.)

Because now we have to test the compiler *and* the version as well?

But I do agree that using the builtins makes for much better code; I'm 
looking at a future change that does this.

Cheers,


Jeremy



pgsql-hackers by date:

Previous
From: "Markus Wanner"
Date:
Subject: Re: PostgreSQL Developer meeting minutes up
Next
From: Florian Weimer
Date:
Subject: Re: [PATCH v2] Add bit operations util header