Warnings in compile - Mailing list pgsql-hackers

From Michael Meskes
Subject Warnings in compile
Date
Msg-id 20090525032440.GA23504@hyperion.credativ.de
Whole thread Raw
Responses Re: Warnings in compile  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

sitting here on my flight back I went through the list of all warnings gcc
spits out when using -Wextra. There are a whole lot of them (~ 1700) that
mostly (except one) fall into one of four classes:

- unused parameters: ~ 600
- some combination of signed and unsigned: ~ 600 Are we really sure that *all* compilers out there do handle this
correctly?
- missing initializer: ~ 500  Probably coming from us initialising structures only partially.
- empty body in else statement: 14 all in backend/commands/copy.c There are some #defines of the form  #define foo
if(1){ ... } else that are called as foo;  I see the need for the macro to expand as block, but what use hase the empty
else?

I assume that the only warning outside these classes is a false positive.

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes@jabber.org
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!


pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: search_path vs extensions
Next
From: Pavel Stehule
Date:
Subject: Re: proposal: SQL parser integration to PL/pgSQL