Re: [PATCH] Compiler warning cleanup - Mailing list pgsql-hackers

On Saturday 23 May 2009 00:04:26 Zdenek Kotala wrote:
> Attached patch fixes following sun studio compiler warning:
>
> "tsquery_op.c", line 193: warning: syntax error:  empty declaration
[snip]

> --- 190,201 ----
>   PG_RETURN_BOOL( CONDITION );                \
>   }
>   
> ! CMPFUNC(tsquery_lt, res < 0)
> ! CMPFUNC(tsquery_le, res <= 0)
> ! CMPFUNC(tsquery_eq, res == 0)
> ! CMPFUNC(tsquery_ge, res >= 0)
> ! CMPFUNC(tsquery_gt, res > 0)
> ! CMPFUNC(tsquery_ne, res != 0)
>   
>   TSQuerySign
>   makeTSQuerySign(TSQuery a)

I think this is not the best way to do it, because it will confuse pgindent 
and editors and such.  The DATA() macros in include/catalog have this solved; 
see include/catalog/genbki.sh.