Re: psql with "Function Type" in \df - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: psql with "Function Type" in \df
Date
Msg-id 200904221500.n3MF0G915720@momjian.us
Whole thread Raw
In response to Re: psql with "Function Type" in \df  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > Still, my original proposal was \df[antw][S+].  The extra brackets are
> > obviously redundant, but if we're about providing cues, this is a good
> > cue IMO.  It allows the [S+] to match the other lines.
>
> I'm for that too.  Bruce was complaining that it'd make the column
> wider, but I don't find that a compelling objection.

OK, I switch to brackets and added separate brackets around the "antw"
options.  I changed "PATTERN" to "PATRN" so I would not have to shift
over _every_ other \? option to align properly;  patch attached and
applied.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
Index: src/bin/psql/help.c
===================================================================
RCS file: /cvsroot/pgsql/src/bin/psql/help.c,v
retrieving revision 1.148
diff -c -c -r1.148 help.c
*** src/bin/psql/help.c    21 Apr 2009 17:23:05 -0000    1.148
--- src/bin/psql/help.c    22 Apr 2009 14:58:16 -0000
***************
*** 205,211 ****
      fprintf(output, _("  \\des[+] [PATTERN]      list foreign servers\n"));
      fprintf(output, _("  \\deu[+] [PATTERN]      list user mappings\n"));
      fprintf(output, _("  \\dew[+] [PATTERN]      list foreign-data wrappers\n"));
!     fprintf(output, _("  \\df[antwS+] [PATTERN]  list (only agg/normal/trigger/window) functions\n"));
      fprintf(output, _("  \\dF[+]  [PATTERN]      list text search configurations\n"));
      fprintf(output, _("  \\dFd[+] [PATTERN]      list text search dictionaries\n"));
      fprintf(output, _("  \\dFp[+] [PATTERN]      list text search parsers\n"));
--- 205,211 ----
      fprintf(output, _("  \\des[+] [PATTERN]      list foreign servers\n"));
      fprintf(output, _("  \\deu[+] [PATTERN]      list user mappings\n"));
      fprintf(output, _("  \\dew[+] [PATTERN]      list foreign-data wrappers\n"));
!     fprintf(output, _("  \\df[antw][S+] [PATRN]  list [only agg/normal/trigger/window] functions\n"));
      fprintf(output, _("  \\dF[+]  [PATTERN]      list text search configurations\n"));
      fprintf(output, _("  \\dFd[+] [PATTERN]      list text search dictionaries\n"));
      fprintf(output, _("  \\dFp[+] [PATTERN]      list text search parsers\n"));

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: psql with "Function Type" in \df
Next
From: Tom Lane
Date:
Subject: Re: [NOVICE] Workaround for bug #4608?