Postgres Pro
Downloads
Home   >   mailing lists

Re: reloptions with a "namespace" - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: reloptions with a "namespace"
Date
Msg-id 20090403193834.GM23023@alvh.no-ip.org
Whole thread Raw
In response to Re: reloptions with a "namespace"  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: reloptions with a "namespace"  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
Alvaro Herrera escribió:
> Khee Chin escribió:
>
> > After some debugging in reloptions.c, I've realised that the issue is
> > caused by fillfactor not having a validnsps in transformRelOptions.
> > Adding an additional condition "&& (validnsps))" at line 595 or 612
> > appears to fix the issue.
>
> No, the bug is that they are passed as DefElem instead of RelOptElem.
> The right fix is in the grammar ... checking now.

This patch seems to be the right cure.  (Some other users of
opt_definition remain; I think it's just CREATE FUNCTION by now).

--
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: reloptions with a "namespace"
Next
From: Tom Lane
Date:
Subject: Re: GetCurrentVirtualXIDs()